Reviewers: Jarin (OOO), Benedikt Meurer,
Description:
[turbofan] Ensure stackcheck flags do something.
While the intention is to eventually do away with
FLAG_turbo_loop_stackcheck and FLAG_turbo_preprocess_range,
they are useful for the interim we are still testing and
benchmarking the feature.
BUG=
Please review this at https://codereview.chromium.org/1314163003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+7, -3 lines):
M src/compiler/ast-graph-builder.cc
M src/compiler/pipeline.cc
Index: src/compiler/ast-graph-builder.cc
diff --git a/src/compiler/ast-graph-builder.cc
b/src/compiler/ast-graph-builder.cc
index
fca0388327547a05bee59ccafba59e97cc2b7ad9..88dc44e3427f89b3ae00d2a1b0f670ce05c4728e
100644
--- a/src/compiler/ast-graph-builder.cc
+++ b/src/compiler/ast-graph-builder.cc
@@ -2932,7 +2932,7 @@ void AstGraphBuilder::VisitInScope(Statement* stmt,
Scope* s, Node* context) {
void AstGraphBuilder::VisitIterationBody(IterationStatement* stmt,
LoopBuilder* loop) {
ControlScopeForIteration scope(this, stmt, loop);
- if (FLAG_turbo_loop_stackcheck) {
+ if (FLAG_turbo_loop_stackcheck |
| !info()->shared_info()->asm_function()) {
Node* node = NewNode(javascript()->StackCheck());
PrepareFrameState(node, stmt->StackCheckId());
}
Index: src/compiler/pipeline.cc
diff --git a/src/compiler/pipeline.cc b/src/compiler/pipeline.cc
index
3a542e6890b5825036b5d54ccda37d404a8ecf9a..12a0780021c15ec855017389c9743957ad62078a
100644
--- a/src/compiler/pipeline.cc
+++ b/src/compiler/pipeline.cc
@@ -1360,13 +1360,17 @@ void Pipeline::AllocateRegisters(const
RegisterConfiguration* config,
CHECK(!data->register_allocation_data()->ExistsUseWithoutDefinition());
}
- Run<SplinterLiveRangesPhase>();
+ if (FLAG_turbo_preprocess_ranges) {
+ Run<SplinterLiveRangesPhase>();
+ }
// TODO(mtrofin): re-enable greedy once we have bots for range
preprocessing.
Run<AllocateGeneralRegistersPhase<LinearScanAllocator>>();
Run<AllocateDoubleRegistersPhase<LinearScanAllocator>>();
- Run<MergeSplintersPhase>();
+ if (FLAG_turbo_preprocess_ranges) {
+ Run<MergeSplintersPhase>();
+ }
if (FLAG_turbo_frame_elision) {
Run<LocateSpillSlotsPhase>();
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
