LGTM with comments.
https://codereview.chromium.org/1304183004/diff/40001/src/parser.h
File src/parser.h (right):
https://codereview.chromium.org/1304183004/diff/40001/src/parser.h#newcode1347
src/parser.h:1347: Variable* var = scope->DeclareParameter(name, mode,
is_optional,
Please revert this unrelated change.
https://codereview.chromium.org/1304183004/diff/40001/src/scopes.cc
File src/scopes.cc (right):
https://codereview.chromium.org/1304183004/diff/40001/src/scopes.cc#newcode469
src/scopes.cc:469: Variable* Scope::DeclareParameter(const AstRawString*
name, VariableMode mode,
And this one.
https://codereview.chromium.org/1304183004/diff/40001/src/scopes.h
File src/scopes.h (right):
https://codereview.chromium.org/1304183004/diff/40001/src/scopes.h#newcode132
src/scopes.h:132: bool is_optional, bool is_rest,
Also undo this change.
https://codereview.chromium.org/1304183004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
