https://codereview.chromium.org/1321543004/diff/1/src/debug/debug.cc
File src/debug/debug.cc (right):
https://codereview.chromium.org/1321543004/diff/1/src/debug/debug.cc#newcode2281
src/debug/debug.cc:2281: Handle<JSFunction>
jsfun(JSFunction::cast(fun));
I think it might be cleaner to just pass in an optional parameter from
FutexEmulation::Wait through Execution::HandleInterrupts to here,
stating that the interrupt comes from futex wait.
https://codereview.chromium.org/1321543004/diff/1/test/cctest/test-debug.cc
File test/cctest/test-debug.cc (right):
https://codereview.chromium.org/1321543004/diff/1/test/cctest/test-debug.cc#newcode7740
test/cctest/test-debug.cc:7740: "\"command\":\"continue\"}";
Please do not use the JSON protocol for tests anymore. Chrome does not
use it. Use the JS API instead.
https://codereview.chromium.org/1321543004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
