Hi Hannes, thanks for the review, here are changes.
--Michael
https://codereview.chromium.org/1314433004/diff/1/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1314433004/diff/1/src/heap/heap.cc#newcode480
src/heap/heap.cc:480: void Heap::ClearAllKeyedStoreICs() {
On 2015/08/26 21:46:33, Hannes Payer wrote:
I do not like that heap owns this method. It has no heap dependencies.
It could
be a static in KeyedStoreIC.
Okay, I've taken the new code and moved it. The call to code_space() in
the old code is a dependency. That branch will disappear when
FLAG_vector_stores is turned on, then discarded.
Also, I put the new code as a static in TypeFeedbackVector, because 1)
in the vector-based world, that is a good home, and 2) I felt much
better about including type-feedback-vector.h in heap.cc, than about
including ic.h! The former is at least a heap object, the latter is a
whole byzantine world that shouldn't be cluttering up heap.cc. :)
https://codereview.chromium.org/1314433004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
