https://codereview.chromium.org/1320843002/diff/1/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1320843002/diff/1/src/heap/heap.h#newcode1231
src/heap/heap.h:1231: void public_set_code_stub_context(Object* value) {
On 2015/08/27 09:25:02, Hannes Payer wrote:
These are not "real" setters. Hence, they should not use the setter
syntax. Why
public_*? Is this the right terminology? I think they are public
because they
are part of the public section in heap.
The "public" prefix is to not clash with the private versions of these
setters. There are private setters for the entire root set on the heap
further down below. As for the naming, I don't have a strong opinion,
choose whatever name you like and I'll rename it. But just FYI, this is
not new, this has been here for ages, I am just unifying it.
https://codereview.chromium.org/1320843002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
