LGTM
https://codereview.chromium.org/1314493007/diff/80001/src/heap/spaces.cc
File src/heap/spaces.cc (right):
https://codereview.chromium.org/1314493007/diff/80001/src/heap/spaces.cc#newcode1004
src/heap/spaces.cc:1004: void
PagedSpace::MergeCompactionSpace(CompactionSpace* other) {
Nice!
https://codereview.chromium.org/1314493007/diff/80001/test/cctest/test-spaces.cc
File test/cctest/test-spaces.cc (right):
https://codereview.chromium.org/1314493007/diff/80001/test/cctest/test-spaces.cc#newcode433
test/cctest/test-spaces.cc:433: CHECK_LE(old_space->CountTotalPages(),
Shouldn't that be equal?
https://codereview.chromium.org/1314493007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
