lgtm with comments.
https://codereview.chromium.org/1312033003/diff/60001/src/builtins.cc
File src/builtins.cc (right):
https://codereview.chromium.org/1312033003/diff/60001/src/builtins.cc#newcode169
src/builtins.cc:169: // This is an extended version of ECMA-262 9.4, but
additionally
This seems to refer to spec version 5.1. Is there an equivalent in
version 6.0? 7.1.11 seems related.
https://codereview.chromium.org/1312033003/diff/60001/src/builtins.cc#newcode175
src/builtins.cc:175: *out =
FastD2IChecked(HeapNumber::cast(object)->value());
Do we have test cases to guarantee that this rounds correctly for
positive and negative numbers? If not, can we have some?
https://codereview.chromium.org/1312033003/diff/60001/src/builtins.cc#newcode181
src/builtins.cc:181: *out = (Oddball::cast(object)->kind() ==
Oddball::kTrue) ? 1 : 0;
You can use object->IsTrue here.
https://codereview.chromium.org/1312033003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
