https://codereview.chromium.org/1320893002/diff/1/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1320893002/diff/1/src/heap/heap.cc#newcode6540
src/heap/heap.cc:6540: if (concurrent_unmaping_tasks_active_ > 0) {
On 2015/08/27 11:37:41, Michael Lippautz wrote:
We could make this more general, so that we can start as many
unmapping
tasks as we like:
while(concurrent_unmapping_tasks_active_ > 0) {
pending_unmap_tasks_semaphore_.Wait();
concurrent_unmapping_tasks_active_--;
}
wdyt?
The intention was to assert if we are waiting for an unexpected number
of tasks. But that may be a bit too static. I will change it to what you
proposed. Done.
https://codereview.chromium.org/1320893002/diff/1/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1320893002/diff/1/src/heap/heap.h#newcode2379
src/heap/heap.h:2379: unsigned int concurrent_unmaping_tasks_active_;
On 2015/08/27 11:37:41, Michael Lippautz wrote:
size_t maybe?
Done.
https://codereview.chromium.org/1320893002/diff/20001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1320893002/diff/20001/src/heap/heap.cc#newcode5764
src/heap/heap.cc:5764: WaitUntilUnmappingOfFreeChunksCompleted();
We should also wait when we tear down the heap.
https://codereview.chromium.org/1320893002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
