I am not a big fan of the involved complexity, but the alternatives are
also not
great. So LGTM.
Please describe in detail what the semantics are and what may happen in
different situation involving incremental marking, scavenges, full gc...
https://codereview.chromium.org/1314863003/diff/120001/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1314863003/diff/120001/src/heap/heap.h#newcode1357
src/heap/heap.h:1357: // collect more garbage.
Explain in detail here how the flags work.
https://codereview.chromium.org/1314863003/diff/120001/src/heap/heap.h#newcode1364
src/heap/heap.h:1364: inline bool CollectGarbageNewSpace(const char*
gc_reason = nullptr);
Also mention here what impact the flags have.
https://codereview.chromium.org/1314863003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
