Reviewers: Mads Ager,
Description:
Elaborating test for Array.shift a bit.
Please review this at http://codereview.chromium.org/596116
Affected files:
M test/mjsunit/array-shift.js
Index: test/mjsunit/array-shift.js
diff --git a/test/mjsunit/array-shift.js b/test/mjsunit/array-shift.js
index
43439ab62193d610675d1395f11ea6c4b4b65b09..4c4ebf31fb9a125d417138882a9c83316e432eda
100644
--- a/test/mjsunit/array-shift.js
+++ b/test/mjsunit/array-shift.js
@@ -34,13 +34,38 @@
// Now check the case with array of holes and some elements on prototype.
(function() {
- var array = new Array(10);
+ var len = 9;
+ var array = new Array(len);
+ Array.prototype[3] = "@3";
Array.prototype[7] = "@7";
- assertEquals(array[0], undefined);
- assertEquals(array[7], Array.prototype[7]);
+
+ assertEquals(len, array.length);
+ for (var i = 0; i < array.length; i++) {
+ assertEquals(array[i], Array.prototype[i]);
+ }
array.shift();
- assertEquals(array[0], undefined);
+ assertEquals(len - 1, array.length);
+ // Note that shift copies values from prototype into the array.
+ assertEquals(array[2], Array.prototype[3]);
+ assertTrue(array.hasOwnProperty(2));
+
+ assertEquals(array[6], Array.prototype[7]);
+ assertTrue(array.hasOwnProperty(6));
+
+ // ... but keeps the rest as holes:
+ Array.prototype[5] = "@5";
+ assertEquals(array[5], Array.prototype[5]);
+ assertFalse(array.hasOwnProperty(5));
+
+ assertEquals(array[3], Array.prototype[3]);
+ assertFalse(array.hasOwnProperty(3));
+
assertEquals(array[7], Array.prototype[7]);
+ assertFalse(array.hasOwnProperty(7));
+
+ delete Array.prototype[3];
+ delete Array.prototype[5];
+ delete Array.prototype[7];
})();
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
