Thanks a lot for review, Mads, committing.

http://codereview.chromium.org/596116/diff/1/2
File test/mjsunit/array-shift.js (right):

http://codereview.chromium.org/596116/diff/1/2#newcode68
test/mjsunit/array-shift.js:68: delete Array.prototype[3];
On 2010/02/15 11:34:02, Mads Ager wrote:
Why do you have these deletes here?  If you want them, you should test
if they
return true or false.

I don't want to pollute Array.prototype object in case we add more
tests.  Wrapped into assertTrue's.

http://codereview.chromium.org/596116

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to