Reviewers: paul.l...,
Message:
Thanks, I've addressed the comments, PTAL.
https://codereview.chromium.org/1310233004/diff/1/src/mips/lithium-codegen-mips.cc
File src/mips/lithium-codegen-mips.cc (right):
https://codereview.chromium.org/1310233004/diff/1/src/mips/lithium-codegen-mips.cc#newcode5595
src/mips/lithium-codegen-mips.cc:5595: __ Branch(false_label, lt, at,
Operand(FIRST_SPEC_OBJECT_TYPE));
On 2015/08/27 17:59:32, paul.l... wrote:
It's a bit dodgy to use 'at' here. It happens to work when the value
is int16_t,
and the condition is not eq/ne. This seems fragile. It looks like you
can
safely use 'scratch'. Please change to that if you agree.
Done.
https://codereview.chromium.org/1310233004/diff/1/src/mips64/lithium-codegen-mips64.cc
File src/mips64/lithium-codegen-mips64.cc (right):
https://codereview.chromium.org/1310233004/diff/1/src/mips64/lithium-codegen-mips64.cc#newcode5782
src/mips64/lithium-codegen-mips64.cc:5782: __ Branch(false_label, lt,
at, Operand(FIRST_SPEC_OBJECT_TYPE));
On 2015/08/27 17:59:32, paul.l... wrote:
Also change at to scratch here (as in mips32 port)
Done.
Description:
MIPS: [es6] Initial steps towards a correct implementation of IsCallable.
Port of https://codereview.chromium.org/1316933002/
BUG=
Please review this at https://codereview.chromium.org/1310233004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+48, -52 lines):
M src/full-codegen/mips/full-codegen-mips.cc
M src/full-codegen/mips64/full-codegen-mips64.cc
M src/mips/lithium-codegen-mips.cc
M src/mips64/lithium-codegen-mips64.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
