Hi Benedikt, thanks!
Okay, I just checked the ic code, and they will MISS if the transitioned
map has
disappeared from the weak cell. I'll do the same in the vector dispatcher.
--Michael
https://codereview.chromium.org/1316953003/diff/1/src/type-info.cc
File src/type-info.cc (right):
https://codereview.chromium.org/1316953003/diff/1/src/type-info.cc#newcode86
src/type-info.cc:86: obj->IsSimd128Value() || (FLAG_vector_stores &&
obj->IsMap())) {
I refactored StoreIsUninitialized(FeedbackVectorICSlot) to be more
"vector-style" code. This eliminated the need for this strange
flag-based addition to the conditional above. The only purpose for that
was to send a signal that there is "something interesting" in the vector
slot. Good vector code should better use a Nexus for those decisions.
https://codereview.chromium.org/1316953003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
