Hello again,
Thanks for the thorough review! Will fix everything mentioned as soon as
possible, hopefully today.
We see two bottlenecks in node.js: one happens during buffer allocation, one
during GC. Both add together and make things slightly slower than they could
potentially be. Here is a benchmark that we are using to figure out exact
numbers: https://gist.github.com/trevnorris/efe36274b0d0a23a78f5 .
This patch cuts down performance overhead by 15% according to Trevor Norris
(it
was a bit bigger on my machine, so it probably fluctuates and depends on the
speed of memory allocation too).
Is there a reason why there is no API to have ArrayBuffer contents allocated
inline in the object itself? Not that we could solely use this API, but in
many
cases it could potentially give us better performance, because of absence of
bookkeeping.
Thank you again,
Fedor.
https://codereview.chromium.org/1316873004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
