Reviewers: Jakob,
Message:
Committed patchset #1 (id:1) to pending queue manually as
d853736623f842b69ec5eb3e34dc07fd7233a00c (tree was closed).
Description:
[test] Properly disable test that doesn't work in GC stress.
The magic "print(i)" work-around was no longer work-arounding correctly,
so we do the right thing instead now.
[email protected]
Please review this at https://codereview.chromium.org/1306843004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+3, -3 lines):
M test/mjsunit/mjsunit.status
M test/mjsunit/regress/regress-crbug-500497.js
Index: test/mjsunit/mjsunit.status
diff --git a/test/mjsunit/mjsunit.status b/test/mjsunit/mjsunit.status
index
8e199946d125b8f1a76589b2f064a9c3677404df..8f538294259241bf3cda5b867b3bc1e6e67c98f5
100644
--- a/test/mjsunit/mjsunit.status
+++ b/test/mjsunit/mjsunit.status
@@ -304,6 +304,9 @@
'unicodelctest': [PASS, NO_VARIANTS],
'unicodelctest-no-optimization': [PASS, NO_VARIANTS],
+ # TODO(jkummerow): Doesn't work correctly in GC stress.
+ 'regress/regress-crbug-500497': [PASS, NO_VARIANTS],
+
# Too slow for gc stress.
'asm/embenchen/box2d': [SKIP],
Index: test/mjsunit/regress/regress-crbug-500497.js
diff --git a/test/mjsunit/regress/regress-crbug-500497.js
b/test/mjsunit/regress/regress-crbug-500497.js
index
2d3d40f0f774061bfe31864bcd1f7d76eb4be320..9117440c2c843fe0b37ee68f5cd059e2b7314d1c
100644
--- a/test/mjsunit/regress/regress-crbug-500497.js
+++ b/test/mjsunit/regress/regress-crbug-500497.js
@@ -13,9 +13,6 @@ function Ctor() {
}
for (var i = 0; i < 120; i++) {
- // This print() is important! Without it, in --gc-stress mode, the
function
- // Ctor is optimized too early. No idea why.
- print(i);
// Make the "a" property long-lived, while everything else is
short-lived.
global.push(Ctor().a);
(function FillNewSpace() { new Array(10000); })();
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
