Reviewers: *Benedikt Meurer, *titzer,
https://codereview.chromium.org/1314473007/diff/1/src/compiler/common-operator.h
File src/compiler/common-operator.h (right):
https://codereview.chromium.org/1314473007/diff/1/src/compiler/common-operator.h#newcode10
src/compiler/common-operator.h:10: #include "src/unique.h"
Removal of includes will be done in another CL, because no longer
including unique.h will open a can or worms throughout the code-base.
https://codereview.chromium.org/1314473007/diff/1/test/unittests/compiler/node-test-utils.h
File test/unittests/compiler/node-test-utils.h (right):
https://codereview.chromium.org/1314473007/diff/1/test/unittests/compiler/node-test-utils.h#newcode76
test/unittests/compiler/node-test-utils.h:76: Matcher<Node*>
IsHeapConstant(Handle<HeapObject> value);
I wasn't able to make the implicit boxing of Handle<T> into a Matcher<T>
work. If it's fine with you, I would like to do that in a follow-up CL.
Any help appreciated.
Description:
[turbofan] Remove usage of Unique<T> from graph.
The usage of Unique<T> throughout the TurboFan IR does not have any
advantage. There is no single point in time when they are initialized
and most use-sites looked through to the underlying Handle<T> anyways.
Also there already was a mixture of Handle<T> versus Unique<T> in the
graph and this unifies the situation to use Handle<T> everywhere.
[email protected],[email protected]
Please review this at https://codereview.chromium.org/1314473007/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+207, -257 lines):
M src/compiler/ast-graph-builder.h
M src/compiler/ast-graph-builder.cc
M src/compiler/common-operator.h
M src/compiler/common-operator.cc
M src/compiler/common-operator-reducer.cc
M src/compiler/ia32/instruction-selector-ia32.cc
M src/compiler/instruction-selector-impl.h
M src/compiler/interpreter-assembler.h
M src/compiler/interpreter-assembler.cc
M src/compiler/js-builtin-reducer.cc
M src/compiler/js-context-specialization.cc
M src/compiler/js-generic-lowering.cc
M src/compiler/js-graph.h
M src/compiler/js-graph.cc
M src/compiler/js-inlining.cc
M src/compiler/js-intrinsic-lowering.cc
M src/compiler/js-operator.h
M src/compiler/js-operator.cc
M src/compiler/js-type-feedback.cc
M src/compiler/js-type-feedback-lowering.cc
M src/compiler/js-typed-lowering.cc
M src/compiler/node-matchers.h
M src/compiler/raw-machine-assembler.h
M src/compiler/representation-change.h
M src/compiler/simplified-operator-reducer.cc
M src/compiler/typer.cc
M src/compiler/x87/instruction-selector-x87.cc
M src/handles.h
M src/handles-inl.h
M src/interpreter/interpreter.cc
M test/cctest/compiler/graph-builder-tester.h
M test/cctest/compiler/test-js-context-specialization.cc
M test/cctest/compiler/test-js-typed-lowering.cc
M test/cctest/compiler/test-representation-change.cc
M test/cctest/compiler/test-run-native-calls.cc
M test/cctest/compiler/test-run-stubs.cc
M test/unittests/compiler/change-lowering-unittest.cc
M test/unittests/compiler/graph-unittest.h
M test/unittests/compiler/graph-unittest.cc
M test/unittests/compiler/interpreter-assembler-unittest.cc
M test/unittests/compiler/js-builtin-reducer-unittest.cc
M test/unittests/compiler/js-context-relaxation-unittest.cc
M test/unittests/compiler/js-type-feedback-unittest.cc
M test/unittests/compiler/js-typed-lowering-unittest.cc
M test/unittests/compiler/node-test-utils.h
M test/unittests/compiler/node-test-utils.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
