Thanks for the comments Igor, addressed 'em...
Michael
https://codereview.chromium.org/1308073010/diff/20001/src/ic/ic.cc
File src/ic/ic.cc (right):
https://codereview.chromium.org/1308073010/diff/20001/src/ic/ic.cc#newcode2166
src/ic/ic.cc:2166: if (object->IsJSObject()) {
On 2015/08/28 12:25:18, Igor Sheludko wrote:
You need all these only if use_ic is true.
Indeed, adding this check.
https://codereview.chromium.org/1308073010/diff/20001/src/ic/ic.cc#newcode2171
src/ic/ic.cc:2171: isolate()->heap()->sloppy_arguments_elements_map();
On 2015/08/28 12:25:18, Igor Sheludko wrote:
I think "&& !is_sloppy(language_mode()" should also be here.
No problemo.
https://codereview.chromium.org/1308073010/diff/20001/src/ic/ic.cc#newcode2181
src/ic/ic.cc:2181: ASSIGN_RETURN_ON_EXCEPTION(isolate(), store_handle,
On 2015/08/28 12:25:18, Igor Sheludko wrote:
Why did you drop "if (store_handle.is_null())" ? What about adding
DCHECK
instead?
I saw that we can't get here with it non_null.
I'll add the DCHECK as you suggest.
https://codereview.chromium.org/1308073010/diff/20001/src/ic/ic.cc#newcode2188
src/ic/ic.cc:2188: if (sloppy_arguments_elements &&
!is_sloppy(language_mode())) {
On 2015/08/28 12:25:18, Igor Sheludko wrote:
"&& !is_sloppy(language_mode()" should be included into
sloppy_arguments_elements definition.
Okay, will do.
https://codereview.chromium.org/1308073010/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
