Reviewers: titzer,
Message:
Neither of these solutions look pleasing/production-ready to me. Maybe you
can
suggest something more elegant. Please see email with more details.
Description:
MIPS64: Fix alignment issue in test-run-native-calls.
BUG=
Please review this at https://codereview.chromium.org/1323663003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1, -5 lines):
M test/cctest/compiler/test-run-native-calls.cc
Index: test/cctest/compiler/test-run-native-calls.cc
diff --git a/test/cctest/compiler/test-run-native-calls.cc
b/test/cctest/compiler/test-run-native-calls.cc
index
f9ef44b084302c006f57ba7177ef308df97a24c8..5365507367e65c009b4c4607a6cd2e26c6548e83
100644
--- a/test/cctest/compiler/test-run-native-calls.cc
+++ b/test/cctest/compiler/test-run-native-calls.cc
@@ -989,10 +989,6 @@ TEST(Float64StackParamsToStackParams) {
void MixedParamTest(int start) {
if (DISABLE_NATIVE_STACK_PARAMS) return;
if (RegisterConfiguration::ArchDefault()->num_double_registers() < 2)
return;
-#ifdef V8_TARGET_ARCH_MIPS64
- // TODO(titzer): MIPS stack doubles can be misaligned.
- if (true) return;
-#endif
// TODO(titzer): mix in 64-bit types on all platforms when supported.
#if V8_TARGET_ARCH_32_BIT
@@ -1046,7 +1042,7 @@ void MixedParamTest(int start) {
Handle<Code> wrapper = Handle<Code>::null();
int32_t expected_ret;
char bytes[kDoubleSize];
- char output[kDoubleSize];
+ char output[kDoubleSize] __attribute__((aligned(8)));
int expected_size = 0;
CSignature0<int32_t> csig;
{
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
