https://codereview.chromium.org/1321773002/diff/60001/src/builtins.cc
File src/builtins.cc (left):
https://codereview.chromium.org/1321773002/diff/60001/src/builtins.cc#oldcode294
src/builtins.cc:294:
Spurious change.
https://codereview.chromium.org/1321773002/diff/60001/src/builtins.cc
File src/builtins.cc (right):
https://codereview.chromium.org/1321773002/diff/60001/src/builtins.cc#newcode551
src/builtins.cc:551: if (!ClampedToInteger(args[1], &relative_start)) {
I think clamping could be wrong if we ever have a fast array larger than
kMaxInt. In this case slice(NaN) and slice(kMinInt-1) would produce
wrong results.
What about renaming it to something else and use the old logic for
IsHeapNumber() case.
https://codereview.chromium.org/1321773002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
