Reviewers: Dan Ehrenberg, Benedikt Meurer, bradnelson, bbudge, gdeepti1,
Message:
Created Revert of [simd.js] Disable SIMD polyfill.
Description:
Revert of [simd.js] Disable SIMD polyfill. (patchset #2 id:20001 of
https://codereview.chromium.org/1305923005/ )
Reason for revert:
Breaks simdjs performance tests. See:
https://paste.googleplex.com/5883927122149376
Original issue's description:
[simd.js] Disable SIMD polyfill.
Disable the polyfill in simd.js tests as the functions for Phase 1 have
been
implemented.
BUG=v8:4124
LOG=N
[email protected], [email protected], [email protected]
Committed: https://crrev.com/749ba3a13558cb018a2ec783e5dfb56d2f8528d8
Cr-Commit-Position: refs/heads/master@{#30452}
[email protected],[email protected],[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4124
Please review this at https://codereview.chromium.org/1308003003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+5, -4 lines):
M test/simdjs/SimdJs.json
M test/simdjs/generate.py
M test/simdjs/harness-adapt.js
Index: test/simdjs/SimdJs.json
diff --git a/test/simdjs/SimdJs.json b/test/simdjs/SimdJs.json
index
3e5eea7501f3adc2aae60c45c98e138fed7a8b77..ae2a32e308c146290125fea1974de07b8c9b5792
100644
--- a/test/simdjs/SimdJs.json
+++ b/test/simdjs/SimdJs.json
@@ -9,6 +9,7 @@
],
"resources": [
"test/simdjs/data/src/benchmarks/base.js",
+ "test/simdjs/data/src/ecmascript_simd.js",
"test/simdjs/harness-adapt.js",
"test/simdjs/harness-finish.js",
"test/simdjs/data/src/benchmarks/kernel-template.js",
@@ -241,4 +242,4 @@
"timeout_arm": 240,
"timeout_arm64": 120,
"units": "ms"
-}
+}
\ No newline at end of file
Index: test/simdjs/generate.py
diff --git a/test/simdjs/generate.py b/test/simdjs/generate.py
index
49a3f639674a2ec981c03522f1da998bb50675c9..b100a94ae66694c322ec54fd3340d7c13cee311e
100755
--- a/test/simdjs/generate.py
+++ b/test/simdjs/generate.py
@@ -37,6 +37,7 @@
'units': 'ms',
'resources': [
'test/simdjs/data/src/benchmarks/base.js',
+ 'test/simdjs/data/src/ecmascript_simd.js',
'test/simdjs/harness-adapt.js',
'test/simdjs/harness-finish.js'
] + ['test/simdjs/data/src/benchmarks/%s.js' % t for t in tests],
Index: test/simdjs/harness-adapt.js
diff --git a/test/simdjs/harness-adapt.js b/test/simdjs/harness-adapt.js
index
4c140525e7f382b074b07298add8a42b619302a8..c90d6cc9d181f571307da929197076cd60a89e6d
100644
--- a/test/simdjs/harness-adapt.js
+++ b/test/simdjs/harness-adapt.js
@@ -21,9 +21,8 @@
}
};
-// To enable SIMD polyfill, load ecmascript_simd.js here and
-// add to resources in SimdJs.json as well as the script to
-// re-generate SimdJs.json.
+// TODO(bbudge): Drop when polyfill is not needed.
+load('ecmascript_simd.js');
load('base.js');
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
