Reviewers: Igor Sheludko,
Description:
Make frames.h usable without handles-inl.h header.
This CL us a pure refactoring that makes an empty compilation unit
including just "frames.h" but not "handles-inl.h" compile without
warnings or errors. This is needed to further reduce the header
dependency tangle.
[email protected]
Please review this at https://codereview.chromium.org/1319423003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+12, -10 lines):
M src/frames.h
M src/frames.cc
Index: src/frames.cc
diff --git a/src/frames.cc b/src/frames.cc
index
8561e557e86fd78211ec5c1d08f163140841d642..0b3534e86f09c89c06e389f70423c10252793a18
100644
--- a/src/frames.cc
+++ b/src/frames.cc
@@ -879,6 +879,15 @@ void JavaScriptFrame::RestoreOperandStack(FixedArray*
store) {
}
+FrameSummary::FrameSummary(Object* receiver, JSFunction* function, Code*
code,
+ int offset, bool is_constructor)
+ : receiver_(receiver, function->GetIsolate()),
+ function_(function),
+ code_(code),
+ offset_(offset),
+ is_constructor_(is_constructor) {}
+
+
void FrameSummary::Print() {
PrintF("receiver: ");
receiver_->ShortPrint();
Index: src/frames.h
diff --git a/src/frames.h b/src/frames.h
index
fdf91246c38982a596dc86564631f142678cb918..940b4730c451fe077a962367e4c50015e464da2a
100644
--- a/src/frames.h
+++ b/src/frames.h
@@ -523,16 +523,9 @@ class StandardFrame: public StackFrame {
class FrameSummary BASE_EMBEDDED {
public:
- FrameSummary(Object* receiver,
- JSFunction* function,
- Code* code,
- int offset,
- bool is_constructor)
- : receiver_(receiver, function->GetIsolate()),
- function_(function),
- code_(code),
- offset_(offset),
- is_constructor_(is_constructor) { }
+ FrameSummary(Object* receiver, JSFunction* function, Code* code, int
offset,
+ bool is_constructor);
+
Handle<Object> receiver() { return receiver_; }
Handle<JSFunction> function() { return function_; }
Handle<Code> code() { return code_; }
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
