https://codereview.chromium.org/1322773002/diff/60001/src/typing-asm.cc
File src/typing-asm.cc (right):
https://codereview.chromium.org/1322773002/diff/60001/src/typing-asm.cc#newcode343
src/typing-asm.cc:343: RECURSE(VisitWithExpectation(stmt->cond(),
cache_.kInt32,
Is this also true? I thought asm allowed naked conditions like if(a < 3)
and do {x } while (a < 4). It certainly allows do .. while(false)
https://codereview.chromium.org/1322773002/diff/60001/src/typing-asm.cc#newcode366
src/typing-asm.cc:366: RECURSE(VisitWithExpectation(stmt->cond(),
cache_.kInt32,
Same.
https://codereview.chromium.org/1322773002/diff/60001/src/typing-asm.cc#newcode435
src/typing-asm.cc:435: "conditional then branch expected to be
integer"));
You have number in the expectation and then number in the comment.
Shouldn't conditions use the expectation of the outer expression passed
down?
https://codereview.chromium.org/1322773002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
