Reviewers: Yang,
https://codereview.chromium.org/1321543004/diff/1/src/debug/debug.cc
File src/debug/debug.cc (right):
https://codereview.chromium.org/1321543004/diff/1/src/debug/debug.cc#newcode2281
src/debug/debug.cc:2281: Handle<JSFunction>
jsfun(JSFunction::cast(fun));
On 2015/08/27 at 06:27:25, Yang wrote:
I think it might be cleaner to just pass in an optional parameter from
FutexEmulation::Wait through Execution::HandleInterrupts to here,
stating that the interrupt comes from futex wait.
Done.
https://codereview.chromium.org/1321543004/diff/1/test/cctest/test-debug.cc
File test/cctest/test-debug.cc (right):
https://codereview.chromium.org/1321543004/diff/1/test/cctest/test-debug.cc#newcode7740
test/cctest/test-debug.cc:7740: "\"command\":\"continue\"}";
On 2015/08/27 at 06:27:25, Yang wrote:
Please do not use the JSON protocol for tests anymore. Chrome does not
use it. Use the JS API instead.
What is the JS API for continue? All I could find was
DebugCommandProcessor.prototype.continueRequest_ in debug.js, which
seems to be only dispatched from the JSON protocol as well.
Description:
[futex] Allow debugger to break in the middle of a futexWait
[email protected]
Please review this at https://codereview.chromium.org/1321543004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+166, -7 lines):
M src/debug/debug.h
M src/debug/debug.cc
M src/execution.h
M src/execution.cc
M src/futex-emulation.cc
M test/cctest/test-debug.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
