Reviewers: ,
https://codereview.chromium.org/1316213005/diff/1/src/debug/debug.cc
File src/debug/debug.cc (right):
https://codereview.chromium.org/1316213005/diff/1/src/debug/debug.cc#newcode1978
src/debug/debug.cc:1978: if (in_nested_debug_scope) {
It is unfortunate that we cannot simply call ProcessDebugEvent here as
it would break order of debug command processing (see e.g.
test-debug/DebugEvaluateWithoutStack) due running command loop on after
compile event. We could pass a flag to ProccessDebugEvent that would
tell it to skip NotifyMessageHandler step but it doesn't look much
better. I wish we could drop this command processing from debug.cc
altogether.
Description:
Extract common debugger code for processing compile events
BUG=chromium:520702
LOG=N
Please review this at https://codereview.chromium.org/1316213005/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+36, -76 lines):
M src/debug/debug.h
M src/debug/debug.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
