Sorry for pushing it out without your ack. I hope this patch looks ok, if
not -
please feel free to revert it.
https://codereview.chromium.org/1316873004/diff/40001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1316873004/diff/40001/src/heap/heap.cc#newcode1805
src/heap/heap.cc:1805: if (freed_memory) {
On 2015/08/31 06:33:45, Michael Lippautz wrote:
Let's make this explcit, i.e., freed_memory > 0
Acknowledged.
https://codereview.chromium.org/1316873004/diff/40001/src/heap/heap.cc#newcode1828
src/heap/heap.cc:1828: if (freed_memory) {
On 2015/08/31 06:33:45, Michael Lippautz wrote:
Ditto here.
Acknowledged.
https://codereview.chromium.org/1316873004/diff/140001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):
https://codereview.chromium.org/1316873004/diff/140001/src/heap/mark-compact.cc#newcode4436
src/heap/mark-compact.cc:4436: // NOTE: ArrayBuffers must be evacuated
first, before freeing them. Otherwise
On 2015/09/01 08:30:06, Michael Lippautz wrote:
Can you elaborate on this comment a bit more. Why are the not yet
discovered? We
should've computed a transitive closure, marking ALL live objects,
icluding new
space ones. This would move them into the live map of buffers.
I might not be understanding this correctly, but we are not really
visiting the new space objects until we are doing the Sweep phase. So we
do erase ptrs in the `not_yet_discovered` only on
`EvacuateNewSpaceAndCandidates` call.
The marking phase do not register them, because it is backed by
`StaticMarkingVisitor`, and only `StaticNewSpaceVisitor` is capable of
registering.
https://codereview.chromium.org/1316873004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
