Reviewers: Jarin, Benedikt Meurer, Mircea Trofin,
Message:
Created Revert of [turbofan] greedy: heuristic for memory operands
Description:
Revert of [turbofan] greedy: heuristic for memory operands (patchset #2
id:40001
of https://codereview.chromium.org/1306823005/ )
Reason for revert:
[Sheriff] Breaks test with greedy allocator:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug%20-%20greedy%20allocator/builds/1318
Original issue's description:
[turbofan] greedy: heuristic for memory operands
When we have a memory operand (HasSpillOperand() == true), and it
doesn't need a register immediately, split in an optimal position, which
is outside the outermost possible loop - just like Linear does.
This results in some modest improvements in perf, when compared
to baseline greedy. In particular Jetstream zlib x64: 4.66%, Life
(Emscripten x64) 11%; largest regression is in AreWeFastYet x64: 8%
and Corrections (Emsccripten x32) 10%
BUG=
Committed: https://crrev.com/8937bfc1d165ff6d72dede1b0ce6f7c1ab9fb260
Cr-Commit-Position: refs/heads/master@{#30498}
[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Please review this at https://codereview.chromium.org/1311813005/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+7, -6 lines):
M src/compiler/greedy-allocator.cc
Index: src/compiler/greedy-allocator.cc
diff --git a/src/compiler/greedy-allocator.cc
b/src/compiler/greedy-allocator.cc
index
5fdacb5e8236992e377c700f9ec9d5176fb8a7df..44f2d4f8160a4893cc3964e21fc0ecb6dd7629e5
100644
--- a/src/compiler/greedy-allocator.cc
+++ b/src/compiler/greedy-allocator.cc
@@ -256,7 +256,7 @@
for (size_t i = 0; i < initial_range_count; ++i) {
auto range = data()->live_ranges()[i];
if (!CanProcessRange(range)) continue;
- if (!range->HasSpillOperand()) continue;
+ if (range->HasNoSpillType()) continue;
LifetimePosition start = range->Start();
TRACE("Live range %d:%d is defined by a spill operand.\n",
@@ -273,11 +273,12 @@
} else if (pos->pos() > range->Start().NextStart()) {
// Do not spill live range eagerly if use position that can benefit
from
// the register is too close to the start of live range.
- auto split_pos = GetSplitPositionForInstruction(
- range, data()->code(), pos->pos().ToInstructionIndex());
- split_pos =
- FindOptimalSplitPos(range->Start().NextFullStart(), split_pos);
-
+ auto split_pos = pos->pos();
+ if (data()->IsBlockBoundary(split_pos.Start())) {
+ split_pos = split_pos.Start();
+ } else {
+ split_pos = split_pos.PrevStart().End();
+ }
Split(range, data(), split_pos);
Spill(range);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
