Reviewers: Hannes Payer (OOO), fedor.indutny,
Message:
Created Revert of heap: make array buffer maps disjoint
Description:
Revert of heap: make array buffer maps disjoint (patchset #8 id:140001 of
https://codereview.chromium.org/1316873004/ )
Reason for revert:
Precautionary revert. The change is incomplete.
Original issue's description:
heap: make array buffer maps disjoint
Remove intersection from the `std::map`s representing current live
ArrayBuffers. While being simpler to understand, it poses significant
performance issue for the active ArrayBuffer users (like node.js).
Store buffers separately, and process them together during mark-sweep
phase.
The results of benchmarks are:
$ ./node-slow bench && ./node-fast bench
4997.4 ns/op
4685.7 ns/op
NOTE: `fast` - was a patched node.js, `slow` - unpatched node.js with
vanilla
v8.
BUG=
Committed: https://crrev.com/9e3676da9ab1aaf7de3e8582cb3fdefcc3dbaf33
Cr-Commit-Position: refs/heads/master@{#30495}
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Please review this at https://codereview.chromium.org/1302233007/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+103, -64 lines):
M src/heap/heap.h
M src/heap/heap.cc
M src/heap/mark-compact.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
