Reviewers: Michael Achenbach, adamk,
Message:
Created Revert of Stop prepending "r" to commit hashes in merge_to_branch.py
Description:
Revert of Stop prepending "r" to commit hashes in merge_to_branch.py
(patchset
#1 id:1 of https://codereview.chromium.org/1298973007/ )
Reason for revert:
Result when using the script:
tools/release/merge_to_branch.py
File "tools/release/merge_to_branch.py", line 108
self["revision_list"] = ", ".join(self["full_revision_list"]))
^
SyntaxError: invalid syntax
Original issue's description:
Stop prepending "r" to commit hashes in merge_to_branch.py
[email protected]
Committed: https://crrev.com/e5dbfd06c3dab5934e846c40af2a8b7fb5cdf0d6
Cr-Commit-Position: refs/heads/master@{#30483}
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Please review this at https://codereview.chromium.org/1321343002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+3, -2 lines):
M tools/release/merge_to_branch.py
Index: tools/release/merge_to_branch.py
diff --git a/tools/release/merge_to_branch.py
b/tools/release/merge_to_branch.py
index
7950fbda345bf8768c9b3ab11474079ad9fa1dc9..5fe3ba42516ea9b6004ee925e3a0bae8e3ebd005
100755
--- a/tools/release/merge_to_branch.py
+++ b/tools/release/merge_to_branch.py
@@ -104,8 +104,9 @@
def RunStep(self):
- # Stringify: ["abcde", "12345"] -> "abcde, 12345"
- self["revision_list"] = ", ".join(self["full_revision_list"]))
+ # Stringify: [123, 234] -> "r123, r234"
+ self["revision_list"] = ", ".join(map(lambda s: "r%s" % s,
+ self["full_revision_list"]))
if not self["revision_list"]: # pragma: no cover
self.Die("Revision list is empty.")
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
