Reviewers: Michael Starzinger, Benedikt Meurer, paul.l..., balazs.kilvady,
Message:
Hi Benedikt, Michael,
This fixes a cctest failure on mips32r6, PTAL.
Thanks,
Akos
Description:
MIPS: Fix QuietSignalingNaNs on mips32r6.
Use the correct sNaN value on mips32r6 also.
TEST=test-api/QuietSignalingNaNs,test-api/Threading1
BUG=
Please review this at https://codereview.chromium.org/1311473007/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+4, -2 lines):
M test/cctest/test-api.cc
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index
3f47e71bdf2ac54d52663444d183f1b8994248a6..a1a2f141e90a7fd88e3953a6c6b535839a7be0d6
100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -15813,7 +15813,8 @@ THREADED_TEST(QuietSignalingNaNs) {
uint64_t stored_bits = DoubleToBits(stored_number);
// Check if quiet nan (bits 51..62 all set).
#if (defined(V8_TARGET_ARCH_MIPS) || defined(V8_TARGET_ARCH_MIPS64)) && \
- !defined(_MIPS_ARCH_MIPS64R6) && !defined(USE_SIMULATOR)
+ !defined(_MIPS_ARCH_MIPS64R6) && !defined(_MIPS_ARCH_MIPS32R6) && \
+ !defined(USE_SIMULATOR)
// Most significant fraction bit for quiet nan is set to 0
// on MIPS architecture. Allowed by IEEE-754.
CHECK_EQ(0xffe, static_cast<int>((stored_bits >> 51) & 0xfff));
@@ -15834,7 +15835,8 @@ THREADED_TEST(QuietSignalingNaNs) {
uint64_t stored_bits = DoubleToBits(stored_date);
// Check if quiet nan (bits 51..62 all set).
#if (defined(V8_TARGET_ARCH_MIPS) || defined(V8_TARGET_ARCH_MIPS64)) && \
- !defined(_MIPS_ARCH_MIPS64R6) && !defined(USE_SIMULATOR)
+ !defined(_MIPS_ARCH_MIPS64R6) && !defined(_MIPS_ARCH_MIPS32R6) && \
+ !defined(USE_SIMULATOR)
// Most significant fraction bit for quiet nan is set to 0
// on MIPS architecture. Allowed by IEEE-754.
CHECK_EQ(0xffe, static_cast<int>((stored_bits >> 51) & 0xfff));
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
