Awesome. Thanks! LGTM with one comment to address.
https://codereview.chromium.org/1309303008/diff/1/src/type-feedback-vector.cc
File src/type-feedback-vector.cc (left):
https://codereview.chromium.org/1309303008/diff/1/src/type-feedback-vector.cc#oldcode5
src/type-feedback-vector.cc:5: #include "src/type-feedback-vector.h"
Please leave this include at the top as it was before. This is according
to the style guide[1] and has the purpose of ensuring that all
_declarations_ needed by src/type-feedback-vector.h are provided by that
header itself (i.e. it is self-contained). It still doesn't guarantee
all _definitions_ are provided though (which is what this CL fixes).
From the style guide[1]: "With the preferred ordering, if dir/foo.h
omits any necessary includes, the build of dir/foo.cc or dir/foo_test.cc
will break. Thus, this rule ensures that build breaks show up first for
the people working on these files, not for innocent people in other
packages."
[1]
https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Names_and_Order_of_Includes
https://codereview.chromium.org/1309303008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
