On 2015/07/20 13:49:24, commit-bot: I haz the power wrote:
Patchset 3 (id:??) landed as
https://crrev.com/fa94ca3ea422bbdc5a2b0d2ad42f7438456a95a9
Cr-Commit-Position: refs/heads/master@{#29752}
While debugging some failures (from
https://codereview.chromium.org/1272673003/)
in tests added by this CL (particularly `f34()` --- probably others), I
found a
problem:
We're lazily compiling the default parameter initializer function, which
becomes
totally separated from the parameter scope where `...a` gets declared. This
works great for eager compilation, but not so great for lazy compilation.
Just to test that this wasn't caused by a problem in my CL, I tried an
experiment on master (29d793728abf24d7078809f128d3f82437855ff2) with no
patches
applied: I tried removing the `...` from the rest parameter, making it a
simple
parameter. It hangs the process.
Simple repro case:
``` test.js
function f({x = function defaultFn() { return a }}, a) { return x()[0] }
f({})
```
``` runner
out/x64.release/d8 --harmony-destructuring --harmony-default-parameters
test.js
```
So, even if the rest parameter issue is my bug, I think it's at least
partially
related to this simple parameter version of the bug
https://codereview.chromium.org/1225413005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
