Moved explicit range checks to bultins.cc and only leave DCHECKs in
elements.cc
https://codereview.chromium.org/1317053006/diff/40001/src/elements.cc
File src/elements.cc (right):
https://codereview.chromium.org/1317053006/diff/40001/src/elements.cc#newcode1317
src/elements.cc:1317: if (len == 0) {
On 2015/09/02 at 12:35:20, Igor Sheludko wrote:
ArrayPop already handles this case. Maybe this should be a DCHECK
instead?
Right.
https://codereview.chromium.org/1317053006/diff/40001/src/elements.cc#newcode1337
src/elements.cc:1337: if (len == 0) {
On 2015/09/02 at 12:35:20, Igor Sheludko wrote:
Same here.
ditto.
https://codereview.chromium.org/1317053006/diff/40001/test/mjsunit/array-natives-elements.js
File test/mjsunit/array-natives-elements.js (right):
https://codereview.chromium.org/1317053006/diff/40001/test/mjsunit/array-natives-elements.js#newcode257
test/mjsunit/array-natives-elements.js:257:
//assertTrue(%HasFastSmiElements(a4));
On 2015/09/02 at 12:35:21, Igor Sheludko wrote:
Why is this assert commented?
I got weird side-effects from this point on when optimized. All of a
sudden the backing stores do no longer have the same type:
https://code.google.com/p/chromium/issues/detail?id=523972
https://codereview.chromium.org/1317053006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
