[v8-dev] PPC: VectorICs: Cleanup, remove unnecessary arguments from HandleArrayCases() (issue 1325103003 by [email protected])

Wed, 02 Sep 2015 07:14:20 -0700 

Reviewers: dstence, joransiu, john.yan, michael_dawson, mvstanton,

Description:
PPC: VectorICs: Cleanup, remove unnecessary arguments from HandleArrayCases() 

Port c29a4061c9a44a90487c411a4b5d2b9aabba9536

[email protected], [email protected], [email protected],
[email protected], [email protected]
BUG=

Please review this at https://codereview.chromium.org/1325103003/

Base URL: https://chromium.googlesource.com/v8/v8.git@master

Affected files (+7, -11 lines):
  M src/ppc/code-stubs-ppc.cc


Index: src/ppc/code-stubs-ppc.cc
diff --git a/src/ppc/code-stubs-ppc.cc b/src/ppc/code-stubs-ppc.cc
index 2f76275f1ef5cf942954da7cbc6c73e15899283d..7395a02922db9f8c4779b2601abe3b6fca928c15 100644 
--- a/src/ppc/code-stubs-ppc.cc
+++ b/src/ppc/code-stubs-ppc.cc
@@ -4569,11 +4569,10 @@ void LoadICStub::GenerateForTrampoline(MacroAssembler* masm) { 
 }


-static void HandleArrayCases(MacroAssembler* masm, Register receiver,
-                             Register key, Register vector, Register slot,
-                             Register feedback, Register receiver_map,
-                             Register scratch1, Register scratch2,
-                             bool is_polymorphic, Label* miss) {
+static void HandleArrayCases(MacroAssembler* masm, Register feedback,
+                             Register receiver_map, Register scratch1,
+                             Register scratch2, bool is_polymorphic,
+                             Label* miss) {
   // feedback initially contains the feedback array
   Label next_loop, prepare_next;
   Label start_polymorphic;
@@ -4690,8 +4689,7 @@ void LoadICStub::GenerateImpl(MacroAssembler* masm, bool in_frame) { 
   __ LoadP(scratch1, FieldMemOperand(feedback, HeapObject::kMapOffset));
   __ CompareRoot(scratch1, Heap::kFixedArrayMapRootIndex);
   __ bne(&not_array);
- HandleArrayCases(masm, receiver, name, vector, slot, feedback, receiver_map, 
-                   scratch1, r10, true, &miss);
+ HandleArrayCases(masm, feedback, receiver_map, scratch1, r10, true, &miss); 

   __ bind(&not_array);
   __ CompareRoot(feedback, Heap::kmegamorphic_symbolRootIndex);
@@ -4751,8 +4749,7 @@ void KeyedLoadICStub::GenerateImpl(MacroAssembler* masm, bool in_frame) { 
   // We have a polymorphic element handler.
   Label polymorphic, try_poly_name;
   __ bind(&polymorphic);
- HandleArrayCases(masm, receiver, key, vector, slot, feedback, receiver_map, 
-                   scratch1, r10, true, &miss);
+ HandleArrayCases(masm, feedback, receiver_map, scratch1, r10, true, &miss); 

   __ bind(&not_array);
   // Is it generic?
@@ -4772,8 +4769,7 @@ void KeyedLoadICStub::GenerateImpl(MacroAssembler* masm, bool in_frame) { 
   __ add(feedback, vector, r0);
   __ LoadP(feedback,
FieldMemOperand(feedback, FixedArray::kHeaderSize + kPointerSize)); - HandleArrayCases(masm, receiver, key, vector, slot, feedback, receiver_map, 
-                   scratch1, r10, false, &miss);
+ HandleArrayCases(masm, feedback, receiver_map, scratch1, r10, false, &miss); 

   __ bind(&miss);
   KeyedLoadIC::GenerateMiss(masm);


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group. 
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to