Reviewers: Kevin Millikin,
Message:
Small code review for you :)
Description:
Make class BitField able to use 32 bits of a uint32.
Although algorithmically correct, the compiler would not allow to
instantiate
a BitField that uses all 32 bits without warnings about a too large shift
count. As a consequence we were limited to 31 bit values when using
BitField.
This happened when instantiating a bitfield BitField<T, shift, size> with
[shift=0, size=32] or [shift=31, size=1] or more general any
[shift=X, size=32-X]
As side-effect of the new implementation the compiler now warns if we ever
try instantiating a bitfield with size 0.
Please review this at http://codereview.chromium.org/606063
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/codegen.h
M src/frame-element.h
M src/objects.h
M src/register-allocator.h
M src/runtime.cc
M src/utils.h
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
