LGTM with nits.
https://codereview.chromium.org/1307943013/diff/1/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (left):
https://codereview.chromium.org/1307943013/diff/1/src/arm/lithium-codegen-arm.cc#oldcode2643
src/arm/lithium-codegen-arm.cc:2643: __ b(gt, is_false);
For the record: I think this signed comparison was actually a bug.
Should've been unsigned.
https://codereview.chromium.org/1307943013/diff/1/src/full-codegen/mips/full-codegen-mips.cc
File src/full-codegen/mips/full-codegen-mips.cc (right):
https://codereview.chromium.org/1307943013/diff/1/src/full-codegen/mips/full-codegen-mips.cc#newcode3689
src/full-codegen/mips/full-codegen-mips.cc:3689: __ GetObjectType(v0,
v0, a1); // Map is now in v8.
s/v8/v0/ :-)
https://codereview.chromium.org/1307943013/diff/1/src/full-codegen/mips64/full-codegen-mips64.cc
File src/full-codegen/mips64/full-codegen-mips64.cc (right):
https://codereview.chromium.org/1307943013/diff/1/src/full-codegen/mips64/full-codegen-mips64.cc#newcode3692
src/full-codegen/mips64/full-codegen-mips64.cc:3692: __
GetObjectType(v0, v0, a1); // Map is now in v8.
s/v8/v0/
https://codereview.chromium.org/1307943013/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
