lgtm, thanks for fixing this immediately :)
https://codereview.chromium.org/1311993003/diff/60001/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1311993003/diff/60001/src/heap/heap.h#newcode843
src/heap/heap.h:843: void FinalizeIncrementalMarkingIfComplete(const
char* comment);
nit: There's a section for incremental marking around line ~1277.
https://codereview.chromium.org/1311993003/diff/60001/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):
https://codereview.chromium.org/1311993003/diff/60001/test/cctest/test-heap.cc#newcode6692
test/cctest/test-heap.cc:6692: }
nit: Please add a comment stating that we are concurrently sweeping and
depend on the timing here.
https://codereview.chromium.org/1311993003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
