On 2015/08/19 at 19:50:35, adamk wrote:
https://codereview.chromium.org/1247243003/diff/20001/src/builtins.cc
File src/builtins.cc (right):
https://codereview.chromium.org/1247243003/diff/20001/src/builtins.cc#newcode951
src/builtins.cc:951: fallback = !IsConcatSpreadable(isolate, obj);
As the test failures show, you can't make this call here, since there are
a
bunch of non-handlified bits of state in local variables which might move
if an
allocation occurs.
I'm about to finish a refactoring of ArrayConcata in
https://codereview.chromium.org/1330483003 which avoids jumping to the
JavaScript code after trying the fast Builtin.
I will try to fix your issue as well using the same approach.
https://codereview.chromium.org/1247243003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
