Reviewers: Mads Ager,
Message:
Mads,
the last of Array methods for you.
Some notes.
1) I found that our current implementation apparently is not complaint to
ECMAScript standard (if I am reading it correctly), is it well-known fact
or do
I misinterpret something? I even found a bug in the spec which sounds
partially
suspicious :) And I would especially appreciate comments on wording in
comments.
2) I am not sure that couple git cl and codereview correctly process
moves---array-functions-prototype-2.js is former array-splice.js which
actually
tests various methods. I needed that name to keep our tests symmetric.
I ran the batch of changes through layout tests and they went fine. Trying
to
run through Sputnik. If there are some other tests, I'd be happy to know.
Description:
Introduce Array.splice builtin.
Please review this at http://codereview.chromium.org/618002
Affected files:
M src/bootstrapper.cc
M src/builtins.h
M src/builtins.cc
A test/mjsunit/array-functions-prototype-2.js
M test/mjsunit/array-splice.js
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
