Reviewers: ulan,
Message:
As discussed.
Description:
Isolate::PrintStack: restore default verbose object printing
Please review this at https://codereview.chromium.org/1311123005/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -2 lines):
M src/heap/heap.cc
M src/string-stream.h
Index: src/heap/heap.cc
diff --git a/src/heap/heap.cc b/src/heap/heap.cc
index
3d8f4492027b93983fc55755c04904751bdcc4e1..f1b8c474a81c486a816d500dd88870a336b0c2da
100644
--- a/src/heap/heap.cc
+++ b/src/heap/heap.cc
@@ -5388,7 +5388,7 @@ void Heap::RecordStats(HeapStats* stats, bool
take_snapshot) {
GetFromRingBuffer(stats->last_few_messages);
if (stats->js_stacktrace != NULL) {
FixedStringAllocator fixed(stats->js_stacktrace, kStacktraceBufferSize
- 1);
- StringStream accumulator(&fixed);
+ StringStream accumulator(&fixed, StringStream::kPrintObjectConcise);
isolate()->PrintStack(&accumulator, Isolate::kPrintStackVerbose);
}
}
Index: src/string-stream.h
diff --git a/src/string-stream.h b/src/string-stream.h
index
d03f1b04c9c89b86583aceddc2a8017ba1c0555b..2f11b182d00684cff90b7726884c567e443d5ff7
100644
--- a/src/string-stream.h
+++ b/src/string-stream.h
@@ -100,7 +100,7 @@ class StringStream final {
public:
enum ObjectPrintMode { kPrintObjectConcise, kPrintObjectVerbose };
StringStream(StringAllocator* allocator,
- ObjectPrintMode object_print_mode = kPrintObjectConcise)
+ ObjectPrintMode object_print_mode = kPrintObjectVerbose)
: allocator_(allocator),
object_print_mode_(object_print_mode),
capacity_(kInitialCapacity),
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
