Reviewers: ,
Message:
The changes we discussed and the unittests you didn't ask for :)
https://codereview.chromium.org/1324153003/diff/20001/src/atomic-utils.h
File src/atomic-utils.h (right):
https://codereview.chromium.org/1324153003/diff/20001/src/atomic-utils.h#newcode16
src/atomic-utils.h:16: template <class T>
I don't think we need the storage type, as it should always be an
AtomicWord.
https://codereview.chromium.org/1324153003/diff/20001/src/atomic-utils.h#newcode89
src/atomic-utils.h:89: void Remove(E element) { ATOMIC_SET_WRITE(&,
~Mask(element)); }
*duck*
https://codereview.chromium.org/1324153003/diff/20001/src/atomic-utils.h#newcode119
src/atomic-utils.h:119: class AtomicFlag {
Maybe another name would fit better.
https://codereview.chromium.org/1324153003/diff/20001/src/atomic-utils.h#newcode126
src/atomic-utils.h:126: return (T)(base::NoBarrier_Load(&value_));
This is a bit unfortunate but I think AtomicFlag<void*> could be useful.
Description:
Add template parameter and unittests to atomic utils.
BUG=
Please review this at https://codereview.chromium.org/1324153003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+250, -18 lines):
M src/atomic-utils.h
M src/heap/heap.h
A test/unittests/atomic-utils-unittest.cc
M test/unittests/unittests.gyp
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
