PTAL

https://codereview.chromium.org/1324153003/diff/20001/src/atomic-utils.h
File src/atomic-utils.h (right):

https://codereview.chromium.org/1324153003/diff/20001/src/atomic-utils.h#newcode17
src/atomic-utils.h:17: class AtomicValue {
This one is now AtomicNumber

https://codereview.chromium.org/1324153003/diff/20001/src/atomic-utils.h#newcode119
src/atomic-utils.h:119: class AtomicFlag {
On 2015/09/04 11:43:19, Michael Starzinger wrote:
On 2015/09/04 11:09:32, Michael Lippautz wrote:
> Maybe another name would fit better.

Yeah, the name is misleading. How about "AtomicVariable", or
"AtomicState"?

AtomicValue it is.

https://codereview.chromium.org/1324153003/diff/20001/src/atomic-utils.h#newcode126
src/atomic-utils.h:126: return (T)(base::NoBarrier_Load(&value_));
On 2015/09/04 11:43:19, Michael Starzinger wrote:
On 2015/09/04 11:09:32, Michael Lippautz wrote:
> This is a bit unfortunate but I think AtomicFlag<void*> could be
useful.

This is uncool. Need to think more about that.

See the new "solution" (I know this is the wrong word...).

https://codereview.chromium.org/1324153003/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to