Reviewers: ulan,
Description:
Remove obsolete DEBUG and NDEBUG macro dance.
The original intention of this seemed to have been to enable DEBUG when
NDEBUG was not defined within Google3. Everything since then was just
added to avoid the "#error" below checking for consistency from firing.
Semantics have also shifted along the way. I vote for dropping this.
[email protected]
Please review this at https://codereview.chromium.org/1315063007/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+0, -16 lines):
M src/v8.h
Index: src/v8.h
diff --git a/src/v8.h b/src/v8.h
index
9bc3b3cd6a8023bfd4b709a0ea492e6c934d9ebc..3035b9ad0738196be42f83a11093595df4f48ed1
100644
--- a/src/v8.h
+++ b/src/v8.h
@@ -8,22 +8,6 @@
#include "include/v8.h"
#include "src/allocation.h"
-#if defined(GOOGLE3) || defined(DCHECK_ALWAYS_ON)
-// Google3 and Chromium special flag handling.
-#if defined(DEBUG) && defined(NDEBUG)
-// V8 only uses DEBUG and whenever it is set we are building a debug
-// version of V8. We do not use NDEBUG and simply undef it here for
-// consistency.
-#undef NDEBUG
-#endif
-#endif // defined(GOOGLE3)
-
-// V8 only uses DEBUG, but included external files
-// may use NDEBUG - make sure they are consistent.
-#if defined(DEBUG) && defined(NDEBUG)
-#error both DEBUG and NDEBUG are set
-#endif
-
namespace v8 {
namespace internal {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
