LGTM with nits.
https://codereview.chromium.org/1309903009/diff/1/src/arm/assembler-arm.cc
File src/arm/assembler-arm.cc (right):
https://codereview.chromium.org/1309903009/diff/1/src/arm/assembler-arm.cc#newcode3678
src/arm/assembler-arm.cc:3678: // Inline buffer is over, switch to
dynamically allocated buffer.
nit: s/over/full/, again below
https://codereview.chromium.org/1309903009/diff/1/src/ic/access-compiler.h
File src/ic/access-compiler.h (right):
https://codereview.chromium.org/1309903009/diff/1/src/ic/access-compiler.h#newcode84
src/ic/access-compiler.h:84: // Ensure that MacroAssembler is reasonably
big.
s/big/small/ ? Or "... has a reasonable size".
https://codereview.chromium.org/1309903009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
