Reviewers: Benedikt Meurer, Jakob, Michael Achenbach,
Message:
If this looks OK, please commit it also, as I will be OOO on Monday. Thanks!
Description:
Fix a -Wsign-compare error under GCC 4.9.2.
BUG=
Please review this at https://codereview.chromium.org/1322693004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+3, -3 lines):
M test/unittests/atomic-utils-unittest.cc
Index: test/unittests/atomic-utils-unittest.cc
diff --git a/test/unittests/atomic-utils-unittest.cc
b/test/unittests/atomic-utils-unittest.cc
index
060973630179aca5174f2d34c9e9cf7131da2d8b..a0d8a6a5085326248f3030294557baf0246becc3
100644
--- a/test/unittests/atomic-utils-unittest.cc
+++ b/test/unittests/atomic-utils-unittest.cc
@@ -16,7 +16,7 @@ TEST(AtomicNumber, Constructor) {
AtomicNumber<size_t> zero_size_t;
AtomicNumber<intptr_t> zero_intptr_t;
EXPECT_EQ(0, zero_int.Value());
- EXPECT_EQ(0, zero_size_t.Value());
+ EXPECT_EQ(0U, zero_size_t.Value());
EXPECT_EQ(0, zero_intptr_t.Value());
}
@@ -27,7 +27,7 @@ TEST(AtomicNumber, Value) {
AtomicNumber<int> b(-1);
EXPECT_EQ(-1, b.Value());
AtomicNumber<size_t> c(1);
- EXPECT_EQ(1, c.Value());
+ EXPECT_EQ(1U, c.Value());
AtomicNumber<size_t> d(static_cast<size_t>(-1));
EXPECT_EQ(std::numeric_limits<size_t>::max(), d.Value());
}
@@ -53,7 +53,7 @@ TEST(AtomicNumber, Increment) {
// Should work as decrement as well.
AtomicNumber<size_t> c(1);
c.Increment(-1);
- EXPECT_EQ(0, c.Value());
+ EXPECT_EQ(0U, c.Value());
c.Increment(-1);
EXPECT_EQ(std::numeric_limits<size_t>::max(), c.Value());
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
