Reviewers: Weiliang,
Message:
PTAL
Description:
X87: [es6] Re-implement rest parameters via desugaring.
port 510baeacbab311798d5e8795800ff773d00d062c (r30550)
original commit message:
Kills the kRestParameter bailout/disabled optimization, and fixes
lazily parsed arrow functions with rest parameters.
Supercedes https://crrev.com/1235153006/
BUG=
Please review this at https://codereview.chromium.org/1305943008/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+0, -49 lines):
M src/full-codegen/x87/full-codegen-x87.cc
M src/x87/code-stubs-x87.cc
Index: src/full-codegen/x87/full-codegen-x87.cc
diff --git a/src/full-codegen/x87/full-codegen-x87.cc
b/src/full-codegen/x87/full-codegen-x87.cc
index
b8ac90660df9610c3f9f736346fd4fc4ece2188b..e9b313ebfdcd84c012f28d6a688695e41a728fe0
100644
--- a/src/full-codegen/x87/full-codegen-x87.cc
+++ b/src/full-codegen/x87/full-codegen-x87.cc
@@ -271,29 +271,6 @@ void FullCodeGenerator::Generate() {
SetVar(new_target_var, eax, ebx, edx);
}
-
- // Possibly allocate RestParameters
- int rest_index;
- Variable* rest_param = scope()->rest_parameter(&rest_index);
- if (rest_param) {
- Comment cmnt(masm_, "[ Allocate rest parameter array");
-
- int num_parameters = info->scope()->num_parameters();
- int offset = num_parameters * kPointerSize;
-
- __ lea(edx,
- Operand(ebp, StandardFrameConstants::kCallerSPOffset + offset));
- __ push(edx);
- __ push(Immediate(Smi::FromInt(num_parameters)));
- __ push(Immediate(Smi::FromInt(rest_index)));
- __ push(Immediate(Smi::FromInt(language_mode())));
-
- RestParamAccessStub stub(isolate());
- __ CallStub(&stub);
-
- SetVar(rest_param, eax, ebx, edx);
- }
-
Variable* arguments = scope()->arguments();
if (arguments != NULL) {
// Function uses arguments object.
Index: src/x87/code-stubs-x87.cc
diff --git a/src/x87/code-stubs-x87.cc b/src/x87/code-stubs-x87.cc
index
5dd777f1878f621b6b4305aed25b9c8b299daceb..ad7a02bdbfa00db44b26bf52bb013622b2738ba0
100644
--- a/src/x87/code-stubs-x87.cc
+++ b/src/x87/code-stubs-x87.cc
@@ -842,32 +842,6 @@ void
ArgumentsAccessStub::GenerateNewStrict(MacroAssembler* masm) {
}
-void RestParamAccessStub::GenerateNew(MacroAssembler* masm) {
- // esp[0] : return address
- // esp[4] : language mode
- // esp[8] : index of rest parameter
- // esp[12] : number of parameters
- // esp[16] : receiver displacement
-
- // Check if the calling frame is an arguments adaptor frame.
- Label runtime;
- __ mov(edx, Operand(ebp, StandardFrameConstants::kCallerFPOffset));
- __ mov(ecx, Operand(edx, StandardFrameConstants::kContextOffset));
- __ cmp(ecx, Immediate(Smi::FromInt(StackFrame::ARGUMENTS_ADAPTOR)));
- __ j(not_equal, &runtime);
-
- // Patch the arguments.length and the parameters pointer.
- __ mov(ecx, Operand(edx, ArgumentsAdaptorFrameConstants::kLengthOffset));
- __ mov(Operand(esp, 3 * kPointerSize), ecx);
- __ lea(edx, Operand(edx, ecx, times_2,
- StandardFrameConstants::kCallerSPOffset));
- __ mov(Operand(esp, 4 * kPointerSize), edx);
-
- __ bind(&runtime);
- __ TailCallRuntime(Runtime::kNewRestParam, 4, 1);
-}
-
-
void RegExpExecStub::Generate(MacroAssembler* masm) {
// Just jump directly to runtime if native RegExp is not selected at
compile
// time or if regexp entry in generated code is turned off runtime
switch or
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
