Thanks a lot, Lasse and Mads. Submitting with proper svn move.
http://codereview.chromium.org/618002/diff/1/3 File src/builtins.cc (right): http://codereview.chromium.org/618002/diff/1/3#newcode533 src/builtins.cc:533: // Not conformant, but that's the way it is currently. On 2010/02/17 09:44:23, Mads Ager wrote:
Could you use the comment from array.js which is more informative than
this one?
// SpiderMonkey and JSC return undefined in the case where no // arguments are given instead of using the implicit undefined // arguments. This does not follow ECMA-262, but we do the same for // compatibility.
Done and updated in regard of TraceMonkey which started to return empty array. KJS renamed to JSC as per IM discussion. http://codereview.chromium.org/618002/diff/1/3#newcode534 src/builtins.cc:534: if (n_arguments == 0) On 2010/02/17 09:44:23, Mads Ager wrote:
Braces around the body or single-line.
Done. http://codereview.chromium.org/618002/diff/1/3#newcode548 src/builtins.cc:548: // but current implementation behaves differently. On 2010/02/17 09:44:23, Mads Ager wrote:
Again, please use the more informative comment from array.js for this
one. Done. http://codereview.chromium.org/618002/diff/1/5 File test/mjsunit/array-functions-prototype-2.js (right): http://codereview.chromium.org/618002/diff/1/5#newcode34 test/mjsunit/array-functions-prototype-2.js:34: var LARGE = 40000000; On 2010/02/17 09:44:23, Mads Ager wrote:
Please make sure that this test does not take a long time. This
should be a
simple test that can be run very quickly. Benchmarks are fine but
should not be
part of the mjsunit test suite.
As discussed by IM, I just attempted to rename this file, didn't modify it. http://codereview.chromium.org/618002 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
