Reviewers: vogelheim, Jakob, Michael Starzinger,
Message:
Created Revert of Deactivate Parser Bookmarks
Description:
Revert of Deactivate Parser Bookmarks (patchset #1 id:1 of
https://codereview.chromium.org/1315173007/ )
Reason for revert:
Tanks performance (Mandreel latency). A simple deactivation will not work.
Original issue's description:
Deactivate Parser Bookmarks.
Bookmarks may create a race condition which
results in syntax errors. The more files are parsed
in parallel the higher the probability that the error
occurs.
Unfortunately it is not possible to simply revert the
CLs related to Bookmarks.
BUG=chromium:527930,chromium:510825
LOG=Y
Committed: https://crrev.com/129593b40eb69d93ba626601bfda046a95cda0e7
Cr-Commit-Position: refs/heads/master@{#30594}
[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:527930,chromium:510825
Please review this at https://codereview.chromium.org/1304413007/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -3 lines):
M src/parser.cc
Index: src/parser.cc
diff --git a/src/parser.cc b/src/parser.cc
index
1fb7adba67a6c079b5709732aa07e0ea0e84f229..319d468e4d61db43f529e8424139842d7bede8ba
100644
--- a/src/parser.cc
+++ b/src/parser.cc
@@ -4168,9 +4168,8 @@
// try to lazy parse in the first place, we'll have to parse eagerly.
Scanner::BookmarkScope bookmark(scanner());
if (is_lazily_parsed) {
- // Deactivate bookmarks for now because they result
- // race conditions while parsing.
- Scanner::BookmarkScope* maybe_bookmark = nullptr;
+ Scanner::BookmarkScope* maybe_bookmark =
+ bookmark.Set() ? &bookmark : nullptr;
SkipLazyFunctionBody(&materialized_literal_count,
&expected_property_count, /*CHECK_OK*/ ok,
maybe_bookmark);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
