lgtm with an optional suggestion. Thanks!
https://codereview.chromium.org/1333463002/diff/1/test/cctest/cctest.h
File test/cctest/cctest.h (right):
https://codereview.chromium.org/1333463002/diff/1/test/cctest/cctest.h#newcode452
test/cctest/cctest.h:452: return v8::Local<v8::Value>();
nit - could you create a helper function:
static inline v8::Local<v8::Value> CompileRun(v8::Local<v8::String>
source, v8::Local<v8::Context> context) {
v8::Local<v8::Value> result;
if (v8::ScriptCompiler::Compile(context, &source)
.ToLocalChecked()
->Run(context)
.ToLocal(&result)) {
return result;
}
return v8::Local<v8::Value>();
}
and use it here, below, and for CompileRun on l:395 (with
v8::Isolate::GetCurrent()->GetCurrentContext() passed as context)?
https://codereview.chromium.org/1333463002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
