As discussed offline, we don't actually need the checks because we cannot
allocate a fixed array that is so large that you will get a fast case
elements
backing store with a length that does not fit in a smi. You could add
ASSERTS
to be safe.
Keeping the tests still seems like a good idea.
http://codereview.chromium.org/601092/diff/1/3
File test/mjsunit/array-splice.js (right):
http://codereview.chromium.org/601092/diff/1/3#newcode289
test/mjsunit/array-splice.js:289: if (false) // Disabled, takes too
long to execute.
Please remove it all then.
http://codereview.chromium.org/601092/diff/1/4
File test/mjsunit/array-unshift.js (right):
http://codereview.chromium.org/601092/diff/1/4#newcode132
test/mjsunit/array-unshift.js:132: if (false) // Disabled, takes too
long to execute.
Please remove it all then.
http://codereview.chromium.org/601092
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
