LGTM, just nits and a suggestion.
https://codereview.chromium.org/1302423007/diff/20001/src/heap/spaces.h
File src/heap/spaces.h (right):
https://codereview.chromium.org/1302423007/diff/20001/src/heap/spaces.h#newcode563
src/heap/spaces.h:563: kPointerSize // intptr_t
write_barrier_counter_
nit: Shouldn't make a difference, but "kIntptrSize" here.
https://codereview.chromium.org/1302423007/diff/20001/src/heap/spaces.h#newcode574
src/heap/spaces.h:574: static const size_t kHeaderSize = kMinHeaderSize
+ kPointerSize;
As discussed offline: This looks like is makes the "markbits" only be
32bit aligned on 64bit machines. If that's the case then we should try
and see if a padding of "kIntSize" here is sufficient, that in turn
would make the "markbits" be 64bit aligned again.
https://codereview.chromium.org/1302423007/diff/20001/src/heap/spaces.h#newcode926
src/heap/spaces.h:926: // Computed offsets should match the compiler
generates ones.
nit: s/generates/generated/
https://codereview.chromium.org/1302423007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
